Repository navigation
Conversation
Mutable class attributes would not scale with more threads, adding defered reference counting to resolve it. ./python_main.exe Tools/ftscalingbench/ftscalingbench.py class_attribute Running benchmarks with 18 threads class_attribute 6.3x slower ./python.exe Tools/ftscalingbench/ftscalingbench.py class_attribute Running benchmarks with 18 threads class_attribute 8.0x faster
3 tasks done
johng
marked this pull request as ready for review
August 15, 2026 23:33
Contributor
Author
|
Happy to create a new issue for this if the linked one is not close enough |
Add a free-threading test that reads a class attribute holding an instance of a different class from a non-owning thread and checks that the failed LOAD_ATTR_CLASS specialization attempt enables deferred reference counting on the value, and that the value is still reclaimed by the GC once unreachable.
Contributor
Author
|
CC @kumaraditya303 @colesbury thanks! |
Contributor
Author
|
Deferred reference counting was added in the branch where mutable class attributes hit, but maybe this can be done at the top of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mutable class attributes would not scale with more threads, adding defered reference counting to the non owning threads reduces the churn.
./python_main.exe Tools/ftscalingbench/ftscalingbench.py class_attribute Running benchmarks with 18 threads
class_attribute 6.3x slower
./python.exe Tools/ftscalingbench/ftscalingbench.py class_attribute Running benchmarks with 18 threads
class_attribute 8.0x faster